Opinion on Electronic ignition for 68 340

I was directed to this by a friend.
Proform Electronic Ignition Distributor Kit Mopar Dodge/Chrysler 273, 318, 340, 360
That's generic, so it will not have the best timing curve for your engine.
The further off the timing is from ideal, the less efficient and responsive it will be.
Probably the closest off-the shelf curve will be the MP distributor copy sold by Rick E.
That has to be used with a Chrysler type ECU, so you're in for that as well and some wiring.
It will have to be set with more initial, and probably richer idle. Possibly as rich as you can adust the original carb - which was intended to be run a little leaner at idle than pre-CAP carbs.